yajra / laravel-datatables-html

Laravel DataTables HTML Builder Plugin
https://yajrabox.com/docs/laravel-datatables/html-installation
MIT License
272 stars 63 forks source link

feat: add exportRender method to be used in datatable-buttons for render pr… #195

Closed mrezagolestan closed 1 year ago

mrezagolestan commented 1 year ago

this commit is about development not bug fix:

i realize a need to render column data for export, i found it by adding Export Class to set how to render export but i couldn't find any thing for render print and i need a centralized render for print & export (for simplicity & integrity) so i added exportRender method to be used for pass a callback function to determine how targeted column data should be rendered for print & export, sample code is shown below: Column::make('used')->title('Use Status')->exportRender(function($row,$data){return $data == 1 ? 'Yes' : 'Not Yet'});

but in this commit just method added and it should be paired to commit 56b94a4482f4273ce57b08b5cd05dbc695dfce22 in laravel-datatable-buttons repo to be pushed for calling callback function which is set in exportRender for rendering column data

please accept that pull request too after this pull request

mrezagolestan commented 1 year ago

#177 pull request should be accept after this pull request

yajra commented 1 year ago

Looks good, can you please fix the failing checks?

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

mrezagolestan commented 1 year ago

yeap i'd been resolve it

yajra commented 1 year ago

Apologies for the late review, released in v10.8.0 🚀 Thanks!