search

yajra / laravel-datatables-html

Laravel DataTables HTML Builder Plugin
https://yajrabox.com/docs/laravel-datatables/html-installation
MIT License
272 stars 61 forks source link

fix: unauthorized columns being displayed by builder #223

Closed Arne1303 closed 2 months ago

Arne1303 commented 2 months ago

Hey Yajra hope you're doing well!

Here is the fix for the unauthorized columns being displayed in the HTML builder. I decided to simply ignore all unauthorized columns when adding columns in the HasColumns trait, that way they are completely absent from the column's collection.

Closes #222

sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Arne1303 commented 2 months ago

Guess I will have to move the new test, maybe into BuilderOptionsTest? Not sure if it belongs there

yajra commented 2 months ago

Released on https://github.com/yajra/laravel-datatables-html/releases/tag/v11.5.1 🚀 Thanks!