improve performance || is complex query

yajra / laravel-datatables

jQuery DataTables API for Laravel

https://yajrabox.com/docs/laravel-datatables

MIT License

4.76k stars 857 forks source link

improve performance || is complex query #3133

Closed abdulrhmansouda closed 7 months ago

abdulrhmansouda commented 7 months ago

remove select param while checking because if we have complex subSelect query it will confuse the result.

in simple query order is not important

Yes

yajra commented 7 months ago

Only a new line was added? Marked as a draft pr.

abdulrhmansouda commented 7 months ago

sorry that was only a test. I pushed my changes. please re-review my pr.

sonarcloud[bot] commented 7 months ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

abdulrhmansouda commented 7 months ago

Hello @yajra, my pr is ready. If you have and problem please let me know.

yajra commented 7 months ago

Reviewing PR #3135 and I think it aims for similar improvements with better backward compatibility and tests. Let's resume the discussion on that PR. Thanks!