yajra / laravel-datatables

jQuery DataTables API for Laravel

https://yajrabox.com/docs/laravel-datatables

MIT License

4.76k stars 858 forks source link

Closed JurianArie closed 2 months ago

JurianArie commented 3 months ago

This PR undoes the deprecation of skipTotalRecords and restores the working of setTotalRecords(0) back to how it was in v10.4.3.

Alternative to #3169. Partially reverts #3157.

OzanKurt commented 3 months ago

I think bringing "skip" back is a great idea!

sonarcloud[bot] commented 3 months ago

Quality Gate passed

yajra commented 2 months ago

Looks good to go for me. Do you approve of this @OzanKurt?

OzanKurt commented 2 months ago

I set my total records and it doesn't count them.

$dataTable->setTotalRecords($kpiValues['total_count']);

$dataTable->skipTotalRecords();

I think we have it now! 😊

This might be a breaking change for people who is using setTotalRecords(0) instead of skipTotalRecords.

yajra commented 2 months ago