Unused Dependency: dompdf?

yajra / laravel-datatables

jQuery DataTables API for Laravel

https://yajrabox.com/docs/laravel-datatables

MIT License

4.76k stars 858 forks source link

Unused Dependency: dompdf? #365

Closed gpmcadamold closed 8 years ago

gpmcadamold commented 8 years ago

There's a requirement for the dompdf/dompdf package defined in composer.json but I can't see it being used anywhere else in the code.

This is causing a dependency collision issue in a project I'm working on, and I'm wondering if that dependency is not longer being used you could remove it from your composer.json?

yajra commented 8 years ago

@gpmcadam, dompdf is used for generating PDF file when exporting the table using Laravel Excel package. Removing it may caused some breaking change on some users?

yajra commented 8 years ago

dompdf is being used on service approach. Please send a PR if possible to fix your issue? Thanks!