yajra / laravel-oci8

Oracle DB driver for Laravel via OCI8
https://yajrabox.com/docs/laravel-oci8
MIT License
829 stars 237 forks source link

feat: Implement compileTables missing method #868

Closed ErDiabIo closed 1 month ago

ErDiabIo commented 2 months ago

Hi,

This pr is for implemente the missing method compileTables from laravel

compileTables

i write the following query for get all table from database

SELECT all_tab_comments.table_name AS "name"
FROM all_tab_comments
         JOIN all_tables ON all_tab_comments.table_name = all_tables.table_name
WHERE all_tab_comments.owner = '{owner}'
  AND all_tab_comments.table_type IN ('TABLE')
ORDER BY all_tab_comments.table_name;
yajra commented 1 month ago

Thank you for the PR, the initial review looks good with a test.

I will review this further as soon as I can.

yajra commented 1 month ago

Maybe MySQL would return more values, I suggest we try to match it. Thanks!

yajra commented 1 month ago

Thanks for the updates, will review this again as soon as I can.

yajra commented 1 month ago

Release on https://github.com/yajra/laravel-oci8/releases/tag/v11.5.0 🚀 Thanks!