search

yajra / laravel-oci8

Oracle DB driver for Laravel via OCI8
https://yajrabox.com/docs/laravel-oci8
MIT License
834 stars 237 forks source link

fix: Added "order by" clause to compileColumnExists #873

Closed peter1701 closed 3 months ago

peter1701 commented 3 months ago

PR for Issue #871

yajra commented 3 months ago

Looks good, please fix the failing test. Thanks!

1) Yajra\Oci8\Tests\Database\Oci8SchemaGrammarTest::testCompileColumnExistsMethod
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'select column_name from all_tab_cols where upper(owner) = upper('schema') and upper(table_name) = upper('test_table')'
+'select column_name from all_tab_cols where upper(owner) = upper('schema') and upper(table_name) = upper('test_table') order by column_id'
yajra commented 3 months ago

Released on https://github.com/yajra/laravel-oci8/releases/tag/v11.5.1 🚀 Thanks!