search

yajra / pdo-via-oci8

PHP PDO_OCI functions via OCI8 extension
Other
88 stars 61 forks source link

fix: Don't suppress exceptions when connecting #121

Closed FrittenKeeZ closed 1 year ago

FrittenKeeZ commented 1 year ago

Related to https://github.com/yajra/laravel-oci8/issues/662

This ensures that the correct exception is delegated to the user, as oci_error() will return FALSE on system related exceptions.

yajra commented 1 year ago

Looks good but the target branch is 3? Should I change the target to 9.0 branch instead?

FrittenKeeZ commented 1 year ago

Looks good but the target branch is 3? Should I change the target to 9.0 branch instead?

I don't see a 9.0 branch - do you mean master?

yajra commented 1 year ago

Oh yes, the master is currently branch 9.0. Thanks!

FrittenKeeZ commented 1 year ago

@yajra master branch is 10 commits behind 3.0 so it doesn't really matter it seems - it's up to you :) It's a minor fix anyway

yajra commented 1 year ago

Oh gosh, sorry I have mixed up https://github.com/yajra/laravel-oci8 and this repo. The current branch on this repo is 3.0. >.<

yajra commented 1 year ago

Released on v3.2.5, thanks! 🍻