3rd argument in Statement::setFetchMode(), $ctorArgs, should allow null

yajra / pdo-via-oci8

PHP PDO_OCI functions via OCI8 extension

Other

88 stars 61 forks source link

3rd argument in Statement::setFetchMode(), $ctorArgs, should allow null #34

Closed nhowell closed 8 years ago

nhowell commented 8 years ago

This fixes the the following error when used with Laravel v5.2.42.

Argument 3 passed to Yajra\Pdo\Oci8\Statement::setFetchMode() must be of the type array, null given.

mstaack commented 8 years ago

please update docblocks...then we can merge i think...@yayra ?

nhowell commented 8 years ago

The docblock for setFetchMode() already has @param array|null $ctorArgs Constructor arguments.. So, actually, this PR makes the function signature match the existing docblock.

Is there anything else that needs updated?

mstaack commented 8 years ago

sry looked at the wrong file... all fine for me

mstaack commented 8 years ago

@yajra please merge

yajra commented 8 years ago

Merged and released on v1.1.1. Thanks 👍