Change regex replacement pattern in prepare

yajra / pdo-via-oci8

PHP PDO_OCI functions via OCI8 extension

Other

88 stars 61 forks source link

Change regex replacement pattern in prepare #38

Closed senojj closed 8 years ago

senojj commented 8 years ago

Fixes #37

yajra commented 8 years ago

@jjware thanks for the PR. It does seems to fix #37 but I think it broke my Laravel application. Doing some more test to find out what might caused it. Thanks!

yajra commented 8 years ago

Found the issue on your pattern. ++ should be replaced with *.

/(?:\'[^\']*\')(*SKIP)(*F)|\?/

Anyways, I will merged this and will do some refactoring using preg_replace_callback. Thanks!

yajra commented 8 years ago

Released on v1.2.1. Thanks a lot! 👍