search

yajra / pdo-via-oci8

PHP PDO_OCI functions via OCI8 extension
Other
88 stars 61 forks source link

bindParam parameter should start at 1. #66

Closed yajra closed 5 years ago

yajra commented 5 years ago

In relation to https://github.com/yajra/laravel-oci8/pull/505 and https://github.com/yajra/pdo-via-oci8/pull/63.

istaveren commented 5 years ago

This is not needed here I think. As you add the number behind a :<string> like :p0 for example. Which is not a ? but a named param.

yajra commented 5 years ago

Yes, it might be or might not. Laravel uses index 1 when bindingValues and thus this change might be needed to conform to the framework's standard implementation. But need to review / check this further as it may cause some breaking change.

https://github.com/laravel/framework/blob/ada35036792e7565b1e0cdf30f0fb7da88b41e1f/src/Illuminate/Database/Connection.php#L570-L578

yajra commented 5 years ago

Indeed, it seems like this not needed. #67 is a better approach.