[2.0] Fix #64 for single bind params

yajra / pdo-via-oci8

PHP PDO_OCI functions via OCI8 extension

Other

88 stars 61 forks source link

Closed istaveren closed 5 years ago

istaveren commented 5 years ago

Fix for issue #64

Including tests to prove it works.

yajra commented 5 years ago

Please fix the conflicts and will check again. Thanks!

istaveren commented 5 years ago

No problem, done.

yajra commented 5 years ago

Checked this and it's not working well with my other package laravel-oci8. Need to dig this further.

yajra commented 5 years ago

Was able to get this working with a related PR https://github.com/yajra/laravel-oci8/pull/505. Will test on some other cases that I might have just to be sure before releasing. Thanks!

istaveren commented 5 years ago

Can this be merged?

yajra commented 5 years ago

Releasing on v2.0 just to be sure it will not break any existing laravel apps. Just in time for new Laravel 6 version too to bump.

Thanks and sorry for the delays.