[2.0] Adding support for PDO::ATTR_STATEMENT_CLASS

yajra / pdo-via-oci8

PHP PDO_OCI functions via OCI8 extension

Other

88 stars 61 forks source link

[2.0] Adding support for PDO::ATTR_STATEMENT_CLASS #70

Closed istaveren closed 5 years ago

istaveren commented 5 years ago

The suggested fix for #69

yajra commented 5 years ago

Looks good but introduces a breaking change.

Anyways, just in time for v2 of the package so it's good to go :). Thanks a lot!

yajra commented 5 years ago

Okay, after testing again after merge. It seems like this broke the implementation of PDO::PARAM_STMT.

I removed the v2 tag I released while digging the issue.

Failing codes for ref:

https://github.com/yajra/laravel-oci8/blob/master/tests/Functional/ProceduresAndFunctionsTest.php#L130

https://github.com/yajra/laravel-oci8/blob/master/src/Oci8/Oci8Connection.php#L277

yajra commented 5 years ago

Sorry had to revert this as it fails the code ref above. Please submit another PR if you can that does not break that implementation or do you have any suggestions on he we can fix it? Thanks a lot.