Added support for PDO-style connection strings

yajra / pdo-via-oci8

PHP PDO_OCI functions via OCI8 extension

Other

88 stars 61 forks source link

Added support for PDO-style connection strings #72

Closed wernerm closed 4 years ago

wernerm commented 4 years ago

Added support for PDO-style connection strings in addition to those supported by oci_connect(). See: https://github.com/yajra/pdo-via-oci8/issues/41
Removed the _getCharset() method.
Did some very minor refactoring.

wernerm commented 4 years ago

Made minor code styling changes to conform to CI. See: https://github.com/yajra/pdo-via-oci8/pull/72/commits/08fab37807373c7bc876caa763d73ede64b91cd4

wernerm commented 4 years ago

This PR was designed to be completely backward-compatible with previously supported (oci_connect() type) connection strings.

yajra commented 4 years ago

Sorry for late response. Will try to review this as soon as I can. Thanks!

yajra commented 4 years ago

I just made a quick test and unfortunately it breaks my other package https://github.com/yajra/laravel-oci8. We should allow TNS configuration.

(1/1) Oci8Exception 
Unsupported driver name
--
in Oci8.php line 74
at Oci8->__construct('(DESCRIPTION = (ADDRESS = (PROTOCOL = TCP)(HOST = ....
.....

wernerm commented 4 years ago

Of course, legacy connection string support should be enabled, that was an oversight on my part. Updates have been made accordingly.

yajra commented 4 years ago

Released on v2.1.0 🚀 🍻