yajra / pdo-via-oci8

PHP PDO_OCI functions via OCI8 extension
Other
88 stars 61 forks source link

Declaration of Yajra\Pdo\Oci8::query($statement, $fetchMode = null, $modeArg = null, $ctorArgs = null) must be compatible with PDO::query(string $query, ?int $fetchMode = null, mixed ...$fetchModeArgs) #86

Closed hpwahyao closed 2 years ago

hpwahyao commented 3 years ago

Summary of problem or feature request

Declaration of Yajra\Pdo\Oci8::query($statement, $fetchMode = null, $modeArg = null, $ctorArgs = null) must be compatible with PDO::query(string $query, ?int $fetchMode = null, mixed ...$fetchModeArgs)

mu1f407 commented 3 years ago

Occurs only on PHP 8. After downgrade to 7.4.15 this error disappear.

mu1f407 commented 3 years ago

Signature of PDO::query() method has changed in 8.0: https://www.php.net/manual/en/migration80.incompatible.php#migration80.incompatible.pdo

I will create PR when I have enough time.

yajra commented 3 years ago

PHP8 is currently supported on v3 / Laravel 8. See https://github.com/yajra/pdo-via-oci8/pull/83 for ref. PR is welcome. Thanks!

yserrata commented 3 years ago

The same issue. yajra/laravel-oci8 8.3 Installed pdo-via-oci8 downgrade from (v3.0.0 => v2.2.0) because pdo-via-oci8 require PHP 8.*^

PHP 7.3 Laravel 8.12

whoilo commented 3 years ago

I have the same issue on php 7.4.22, dont know why. Downgrade from 8.4.1 to 8.2.2 helps

williemwewa commented 2 years ago

No other resolution to this issue? Am using oracle 19 and php 8

yajra commented 2 years ago

When using PHP 8 & 8.1, use v3. Anything below 8, use v2 of the package.