search

yajra / pdo-via-oci8

PHP PDO_OCI functions via OCI8 extension
Other
88 stars 61 forks source link

[3.x] Add missing property types and return types for PHP 8.1 #95

Closed danielrona closed 2 years ago

danielrona commented 2 years ago

This pull should fix a couple of bugs and implement PHP8.1 for the most, so far I've not run into any issues as of yet

yajra commented 2 years ago

I've fixed and added a PHP8.1 github action on master branch. Can you please rebase on master and check if tests are working? I cannot update to PHP8 & 8.1 yet so I can't check this thoroughly. Thanks!

yajra commented 2 years ago

@danielrona changes looks good and tests are passing.

Requesting review from other users. If no response in a week or two, will merge this. Thanks!

X-Coder264 commented 2 years ago

@yajra Any plans to merge and tag a release with this soon? We've just deployed Laravel 9 + PHP 8.1 to prod and our Sentry is full of these deprecation messages now.

yajra commented 2 years ago

Unfortunately, can't upgrade yet. if you can confirm that this is working then I guess I can release this asap.

X-Coder264 commented 2 years ago

I can do some basic testing over the weekend and let you know if my code still works with these changes.

robsontenorio commented 2 years ago

@X-Coder264 what branch do you use for Laravel 9 + PHP 8.1 ?

yajra commented 2 years ago

Sorry for late checking, I am now finally able to use 8.1 and can confirm that deprecate warning were fixed. Will be included in the next release.

yajra commented 2 years ago

Released on v3.2.1, thanks! 🚀