search

yakaz / elasticsearch-action-updatebyquery

ElasticSearch Update By Query action plugin
113 stars 24 forks source link

upgraded to ES 1.0.0.Beta2 #9

Closed baxford closed 10 years ago

baxford commented 10 years ago

Hi,

Thanks again for this plugin - I previously put in a pull request for upgrade and here's another one!

this is a pull request for an upgrade to Elasticsearch 1.0.0.Beta2 It's only very minor changes in the pom and src/main/java/org/elasticsearch/action/updatebyquery/TransportShardUpdateByQueryAction.java

However, I am seeing some failures in the integration tests: org.elasticsearch.test.integration.updatebyquery.UpdateByQueryTests

When waiting for the cluster to be green, it is timing out and getting a yellow status. If I comment out these lines in the tests, they pass: assertThat(clusterHealth.isTimedOut(), equalTo(false)); assertThat(clusterHealth.getStatus(), equalTo(ClusterHealthStatus.GREEN)); but I'm not sure why this consistently fails.

It's possibly a change to the cluster setup, or possibly something about my environment. I'm just wondering if these tests pass for you? I will keep looking in the meantime.

thanks Bob.

ofavre commented 10 years ago

The changes are compatible from 1.0.0.Beta1, no need for Beta2. The tests work fine for me...

Could you please test this version? Don't forget to mvn clean. Maybe clean your maven repository for elasticsearch-related artifacts.

I can't spot anything wrong with the assertions you're quoting. See ElasticsearchIntegrationTest.ensureGreen().

baxford commented 10 years ago

thanks, I think it's all fine then, I'll use your latest version!

regards, Bob Axford

Bob Axford M: 0413 770 149 E: bob@figjamit.com.au

On Mon, Jan 6, 2014 at 10:06 PM, Olivier Favre notifications@github.comwrote:

The changes are compatible from 1.0.0.Beta1, no need for Beta2. The tests work fine for me...

Could you please test this version? Don't forget to mvn clean. Maybe clean your maven repository for elasticsearch-related artifacts.

I can't spot anything wrong with the assertions you're quoting. See ElasticsearchIntegrationTest.ensureGreen()https://github.com/elasticsearch/elasticsearch/blob/master/src/test/java/org/elasticsearch/test/ElasticsearchIntegrationTest.java#L441 .

— Reply to this email directly or view it on GitHubhttps://github.com/yakaz/elasticsearch-action-updatebyquery/pull/9#issuecomment-31641166 .

ofavre commented 10 years ago

Pushed and released!