yakivmospan / github-wikito-converter

Generate HTML & PDF documentation from Github wiki or any other markdown-based wiki.
Other
296 stars 52 forks source link

No inlining of .gif #36

Open 2xyo opened 6 years ago

2xyo commented 6 years ago

.gif inlining is not working as expected

$ sudo npm install -g github-wikito-converter
/usr/bin/gwtc -> /usr/lib/node_modules/github-wikito-converter/dist/cli/gwtc.js
+ github-wikito-converter@1.5.1
added 40 packages from 304 contributors in 7.572s

$ git clone https://github.com/aol/moloch.wiki.git

$ gwtc -v moloch.wiki/
debug:   gwc launched with options format=html, output=./, filename=documentation, title=Documentation , logoImage=null, footer=null, pdfPageCount=null, tocFile=null, tocLevel=3, highlightTheme=github, userCssFile=null, verbose=true, disableInlineAssets=false
debug:   Found 17 markdown files and 17 links pointing to them in TOC
debug:   Generating html: 15 pages to generate
info:    html file written: documentation.html
documentation.html

$ grep .gif documentation.html |tail -n 4
<p><a href="#SingleHostMoloch.gif">SingleHostMoloch.gif</a></p>
<p><a href="#MultiHostMoloch.gif">MultiHostMoloch.gif</a></p>
<p><a href="#HighTrafficMoloch.gif">HighTrafficMoloch.gif</a></p>
<p><a href="#MultiClusterMoloch.gif">MultiClusterMoloch.gif</a></p>

Expected result : the 4 .gif should be inlined (see https://github.com/aol/moloch/wiki/Architecture#single-host )

$ lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux 9.5 (stretch)
Release:    9.5
Codename:   stretch

$ nodejs --version
v10.13.0