it's overriding window.self variable

yakovlevga / letterpic

LetterPic is a small jQuery plugin that converts user's name to userpic, using it's initials.

MIT License

34 stars 9 forks source link

it's overriding window.self variable #2

Closed sasawant closed 7 years ago

sasawant commented 7 years ago

It's a nice plugin. Found one critical issue. It's overriding the window.self variable, and thus my other js libraries (or any other plugin which depends on window.self object) are not working correctly. Please check line no. 36 in jquery.letterpic.js. It should be "var self = this; "

yakovlevga commented 7 years ago

@sasawant, thanks a lot for noticing this typo! I fixed it.

sasawant commented 7 years ago

Thanks a lot :-)

On Fri, Jul 14, 2017 at 12:10 AM, George Yakovlev notifications@github.com wrote:

@sasawant https://github.com/sasawant, thanks a lot for noticing this typo! I fixed it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yakovlevga/letterpic/issues/2#issuecomment-315166191, or mute the thread https://github.com/notifications/unsubscribe-auth/APbNF8kpFtl-5uR1GlWLx3CXIDU8Nm8fks5sNmSvgaJpZM4OWtXo .