search

yakra / DataProcessing

Data Processing Scripts and Programs for Travel Mapping Project
0 stars 0 forks source link

waypoint simplification: order checks by frequency #100

Open yakra opened 5 years ago

yakra commented 5 years ago

This may already be done; could be there's nothing to do here.

type count
Straightforward intersection: 81393
Straightforward concurrency: 64080
Exit/Intersection: 24640
Keep failsafe: 14220
3+ intersection: 11720
Exit number: 11541
Appended region: 6847
yakra commented 4 years ago

Yes, there is something to do. Current ordering:

type count
Straightforward concurrency: 63983
Straightforward intersection: 78299
Exit/Intersection: 23849
3+ intersection: 11292
Exit number: 11509
Keep failsafe: 11170

Worth noting that there are 3020 (21%) fewer labels keeping the failsafe now. And fewer everything else too. I assume that the figures in the OP are from when multiple concurrent systems were in place during FRA's breakup.

yakra commented 4 years ago

No discernable difference in processing time.

Python: Will not change. No point in cluttering up the repo with DIFFs that don't do anything. C++: I'll go ahead and change this anyway, as I'll be reorganizing this part of the code in the process of implementing https://github.com/TravelMapping/DataProcessing/issues/93

yakra commented 4 years ago

This will in fact need to change in Python, so as to not differ from C++ WRT the Straightforward intersection improvements.

From https://github.com/TravelMapping/DataProcessing/issues/90#issuecomment-557319736:

yakra@BiggaTomato:~/TravelMapping/yakra/DataProcessing/siteupdate/cplusplus/logs$ diff waypointsimplification.old waypointsimplification.i5 | egrep '^< Straightforward concurrency'
< Straightforward concurrency: L3238Her@L3238&L3238Mar@L3238 -> L3238Her/L3238Mar@L3238
< Straightforward concurrency: B279@B279&B279Hol@B279 -> B279/B279Hol@B279
< Straightforward concurrency: A329@A329_E&A329Rea@A329_E -> A329/A329Rea@A329_E
yakra@BiggaTomato:~/TravelMapping/yakra/DataProcessing/siteupdate/cplusplus/logs$ egrep 'L3238Her@L3238&L3238Mar@L3238|B279@B279&B279Hol@B279|A329@A329_E&A329Rea@A329_E' waypointsimplification.i5
Straightforward intersection: L3238Her@L3238&L3238Mar@L3238 -> L3238/L3238
Straightforward intersection: B279@B279&B279Hol@B279 -> B279/B279
Straightforward intersection: A329@A329_E&A329Rea@A329_E -> A329_E/A329_E
yakra commented 4 years ago

ddd602e6969734bd3d6c22908a58149dc40d422f

yakra commented 4 years ago

Right now:

Python: 3+ before Exit# C++: Exit# before 3+

yakra commented 3 years ago

Don't necessarily want to strictly order by frequency. Worth considering...