macros -> lambdas

[yakra]

macros

Every macro you write makes you less 1337.

-Some random person on the internet.

While not 100% the case across the board, there's some truthiness to it. Lambdas will work in many cases. Advantages include:

• Safer
• Smaller program size
• Speed? Instruction cache?

Can't get rid of all of them, but here are some candidates:

• [ ] Just use a reference for this one, not a lambda, but including it anyway. https://github.com/yakra/DataProcessing/blob/387c99b0c260938c870457bb9793d4f78b09987f/siteupdate/cplusplus/functions/sql_file.cpp#L496
• [ ] https://github.com/yakra/DataProcessing/blob/387c99b0c260938c870457bb9793d4f78b09987f/siteupdate/cplusplus/classes/HighwaySystem/route_integrity.cpp#L17
• [ ] https://github.com/yakra/DataProcessing/blob/387c99b0c260938c870457bb9793d4f78b09987f/siteupdate/cplusplus/classes/Waypoint/Waypoint.cpp#L203
• [ ] Binary size down 4000 B. Gets used 8 times. https://github.com/yakra/DataProcessing/blob/387c99b0c260938c870457bb9793d4f78b09987f/siteupdate/cplusplus/classes/Waypoint/Waypoint.cpp#L490
• [ ] This may not work, with the continue in the lambda and not the body of the loop itself? Try it & see what happens. https://github.com/yakra/DataProcessing/blob/387c99b0c260938c870457bb9793d4f78b09987f/siteupdate/cplusplus/classes/Route/read_wpt.cpp#L55
• [ ] https://github.com/yakra/DataProcessing/blob/387c99b0c260938c870457bb9793d4f78b09987f/siteupdate/cplusplus/classes/Args/Args.cpp#L30
• [x] Eventually, the need for these macros will go away entirely. But that's a heavyweight operation that'll take some time to get around to. In the interim, could this maybe have an effect if it's easier on instruction cache? Edit: Deleted in 897c23112e36bf3f20aa0bcc6c5a36f64aba87f1. No need for a lambda. https://github.com/yakra/DataProcessing/blob/387c99b0c260938c870457bb9793d4f78b09987f/siteupdate/cplusplus/classes/GraphGeneration/get_subgraph_data.cpp#L38-L39
• [x] Eventually, HGEdge::detach may go away entirely (another heavyweight opeation). If this does help in the interim; it'll be low-impact; edge compression is already pretty fast and may get faster. Edit: It's still here, just smaller & called less often. The lambda is invoked twice, as opposed to the macro being invoked 6 times. https://github.com/yakra/DataProcessing/blob/387c99b0c260938c870457bb9793d4f78b09987f/siteupdate/cplusplus/classes/GraphGeneration/HGEdge.cpp#L122-L127
• [ ] https://github.com/yakra/DataProcessing/blob/387c99b0c260938c870457bb9793d4f78b09987f/siteupdate/cplusplus/classes/TravelerList/TravelerList.cpp#L126-L129

---

other stuff

• [ ] datacheck boilerplate A couple examples are above already, but in general, look for Datacheck::add.
• [ ] sorting grep -n 'sort([^)]' \`find . -name \*.cpp`
  • [ ] Sorting regions.csv lines & eliminating the 1 use of sort_1st_csv_field reduces binary size 144 B.
  • [ ] sort_route_updates_oldest
  • [ ] What if a function is used multiple times, i.e. sort_root_at_label (5x)?