search

yakultbottle / pe

0 stars 0 forks source link

Select command gives wrong correct percentage when there's insufficient number of topics #4

Open yakultbottle opened 1 week ago

yakultbottle commented 1 week ago

I defined a question of my own, using the example in the UG:

add Flashcards /q The keyword used to define a class is ____. /a class

By doing so, I was able to run the select command without crashing. However, when I ran it with these arguments:

select /d untimed /t random
2
1

Where I called it with 2 topics even though there is only one topic, it automatically cuts my score to 50% despite getting all questions(1/1) correct.

image.png

nus-se-bot commented 4 days ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

JAR file cannot run quiz properly without using pre-downloaded Data files

JAR files require pre-filled .txt files to run with questions as intended. Running the JAR files without these questions lead to the app crashing when the user tries to start a quiz. This was not specified in the UG.

image.png

image.png

Data files which need to be downloaded

[original: nus-cs2113-AY2425S1/pe-interim#196] [original labels: severity.Medium type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The team claims that this bug is due to not downloading the Data files from the GitHub, but I disagree. I downloaded the data files from GitHub, and this bug is still present.

In the data file, there are 19 pre-defined topics. I then tested this with a test case of

select /d untimed /t random
20
1

meaning to choose 20 topics(exactly 1 more than than 19) and 1 question for each topic.

image.png

When I still had one question left, the quiz ended abruptly, as can be seen by how I had 1 question left and the quiz ends.

image.png

This can be further shown by choosing even more than 20 topics, ie 100 topics, here:

image.png

image.png

## :question: Issue severity Team chose [`severity.High`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** Since this bug is not a duplicate of the data file issue, it should not inherit the "High" severity level. I believe it is low since it is not a very frequent bug.