search

yakyak / hangupsjs

google hangouts client library for nodejs
226 stars 46 forks source link

Fix email and self_entity changing ids server-side. And initial conv list. #104

Closed HomerSp closed 5 years ago

HomerSp commented 5 years ago

As the title says, this fixes the ids of email and self_entity, as well as fixing conversation states no longer being sent in the init message by running sync after initializing. Wasn't sure what to do about conv_states being initialized to ds:20 still, so I left it as it doesn't seem to do any harm.

This fixes #103

cgatesman commented 5 years ago

Please do not comment on pull requests if you don't know what you are doing or how to apply and test it properly.

smammy commented 5 years ago

@psouza4 @edraven this is not the place to ask for tech support. Please refer to https://github.com/yakyak/yakyak/issues/981#issuecomment-433029188

nicholashudson2 commented 5 years ago

I was able to apply the changes in the three commits associated with this pull request, compile, and run without any issues. Connection was established quickly, message history populated as expected, and no error messages were encountered. Have been testing off and on throughout the day today, and so far, it's been smooth sailing. @HomerSp Good work! Problem appears to be resolved, tests are passing consistently, and I've yet to encounter any errors/exceptions.

Mange commented 5 years ago

I manually modified the compiled code with what I think the resulting JS would look like, and I can also confirm that this works for me. Thank you!

(It's been some time since I wrote CoffeeScript, but I could also use the code around it to remind me of how the JS should look like.)

blondehouse commented 5 years ago

Hi all, I'm brand new to coding and understanding patches. Can someone walk me through on how I can fix this same issue i've been having? I'm running 1.5.2 on Mojave. Thanks!

smammy commented 5 years ago

@blondehouse this fix is in a subcomponent and not a straightforward patch so you're probably better off waiting for the YakYak release (which looks like it's in progress).

averissimo commented 5 years ago

@smammy exactly!

@blondehouse we're doing the necessary steps to release a new yakyak version in the next hour or so

blondehouse commented 5 years ago

@smammy @averissimo Thank you guys!!

averissimo commented 5 years ago

@HomerSp @smammy @akholodenko thanks for the patch and peer review of code. We appreciate so much.

We'd welcome more patches and new blood in hangupsjs ;)

HomerSp commented 5 years ago

You're very welcome - glad I could help! If I do any more work on it I will certainly send in more pull requests.