search

yalabot / angular-foundation

http://pineconellc.github.io/angular-foundation/
Other
1.05k stars 267 forks source link

Enable/disable closing dropdown via aria-autoclose attribute #230

Open bgilhome opened 9 years ago

bgilhome commented 9 years ago

Implements current Foundation's method of specifying an aria-autoclose attribute on elements to either enable/disable closing a dropdown. Elements contained within a dropdown can be disabled from closing the dropdown by adding aria-autoclose="false".

I've also allowed specifying the attribute on the dropdown element itself to disable click on all contained elements from closing the dropdown, unless they specify an attribute aria-autoclose="true".

ridespirals commented 9 years ago

:+1: I'd really like to see this merged in.

NickClark commented 9 years ago

:+1:

jbrowning commented 8 years ago

Thanks for sending this in @bgilhome and sorry for the (very) late reply. A couple things:

  1. This depends on jQuery and we advertise no dependence on anything other than Angular and the Foundation CSS.
  2. We don't prefix any of our other attributes with aria so it wouldn't make sense for us to do this here.
  3. This is missing documentation and tests.