Open ProLoser opened 9 years ago
Unless something recently changed I'm pretty sure you are mistaken. Where did you find a jquery dependency?
On Thu, 18 Jun 2015 6:57 pm Dean Sofer notifications@github.com wrote:
I was reading your open pull requests, like #117 https://github.com/pineconellc/angular-foundation/pull/117 and other issues and was like "Why do we need this? There is no jQuery dependency". And then I poked around and realize there is in fact one.
Which begs the question: why?
angular-ui-bootstrap does not have one, and even the $position module is an attempt to get rid of one, so what code in here still uses it? I feel like that's a fairly critical concern.
— Reply to this email directly or view it on GitHub https://github.com/pineconellc/angular-foundation/issues/236.
In bower
On Thu, Jun 18, 2015, 10:04 AM Rickert Mulder notifications@github.com wrote:
Unless something recently changed I'm pretty sure you are mistaken. Where did you find a jquery dependency?
On Thu, 18 Jun 2015 6:57 pm Dean Sofer notifications@github.com wrote:
I was reading your open pull requests, like #117 https://github.com/pineconellc/angular-foundation/pull/117 and other issues and was like "Why do we need this? There is no jQuery dependency". And then I poked around and realize there is in fact one.
Which begs the question: why?
angular-ui-bootstrap does not have one, and even the $position module is an attempt to get rid of one, so what code in here still uses it? I feel like that's a fairly critical concern.
— Reply to this email directly or view it on GitHub https://github.com/pineconellc/angular-foundation/issues/236.
— Reply to this email directly or view it on GitHub https://github.com/pineconellc/angular-foundation/issues/236#issuecomment-113222297 .
Right. Jquery is only used in the unit tests. It is not required to use the library.
On Thu, 18 Jun 2015 7:07 pm Dean Sofer notifications@github.com wrote:
In bower
On Thu, Jun 18, 2015, 10:04 AM Rickert Mulder notifications@github.com wrote:
Unless something recently changed I'm pretty sure you are mistaken. Where did you find a jquery dependency?
On Thu, 18 Jun 2015 6:57 pm Dean Sofer notifications@github.com wrote:
I was reading your open pull requests, like #117 https://github.com/pineconellc/angular-foundation/pull/117 and other issues and was like "Why do we need this? There is no jQuery dependency". And then I poked around and realize there is in fact one.
Which begs the question: why?
angular-ui-bootstrap does not have one, and even the $position module is an attempt to get rid of one, so what code in here still uses it? I feel like that's a fairly critical concern.
— Reply to this email directly or view it on GitHub https://github.com/pineconellc/angular-foundation/issues/236.
— Reply to this email directly or view it on GitHub < https://github.com/pineconellc/angular-foundation/issues/236#issuecomment-113222297
.
— Reply to this email directly or view it on GitHub https://github.com/pineconellc/angular-foundation/issues/236#issuecomment-113222933 .
@circlingthesun so make it a dev dependency instead. A lot of people use automated build tools that concatenate all bower repos together.
If you look at the repository used by bower https://github.com/pineconellc/angular-foundation-bower/blob/master/bower.json, you'll see that its not actually a depedency.
Ah. Well... I guess you guys can treat this issue how you see fit.
I think you should make all the current dependencies in THIS repo dev-dependencies, and whatever is used in the bower repo should be this repo's non-dev dependencies
I was reading your open pull requests, like #117 and other issues and was like "Why do we need this? There is no jQuery dependency". And then I poked around and realize there is in fact one.
Which begs the question: why?
angular-ui-bootstrap
does not have one, and even the$position
module is an attempt to get rid of one, so what code in here still uses it? I feel like that's a fairly critical concern.