fix(modal): should not get value property when modal is undefined

yalabot / angular-foundation

http://pineconellc.github.io/angular-foundation/

Other

1.05k stars 267 forks source link

fix(modal): should not get value property when modal is undefined #260

Closed YvonneYu closed 8 years ago

YvonneYu commented 8 years ago

Hi,

We found out that it will though exception by calling 'value' property when no modal instance exist. exception: TypeError: Cannot read property 'value' of undefined

Moreover, we found out there is similar issue for angular-bootstrap. Thus, the same fixed will fix in angualr-foundation as well. https://github.com/angular-ui/bootstrap/pull/1972

Hope it help. Thank you

jbrowning commented 8 years ago

:+1: thanks for sending this in, @YvonneYu.