search

yalabot / angular-foundation

http://pineconellc.github.io/angular-foundation/
Other
1.05k stars 267 forks source link

fix(topbar): disallow scope.apply when topbar is not sticky #306

Open Neil-Ni opened 8 years ago

Neil-Ni commented 8 years ago

What kind of change does this PR introduce?: performance improvement What is the current behavior?: I noticed this when I was doing profiling on my application: screen shot 2016-06-09 at 3 12 47 pm Currently if the top bar is not specified as sticky in anyway it still tries to call scope.$apply, which can potentially slow down the application. In my case, the application is relatively large, and the slowness starts to get noticeable. What is the new behavior?: it doesn't run scope.apply if topBar is not sticky Does this PR introduce a breaking change?: no

thanks!

terotil commented 8 years ago

We are bitten by this quite heavily.

@jbrowning any plans to check this (and the pile of other) PR's? If not (and it is perfectly OK!) it would be cool to find a new maintainer or core team.

terotil commented 8 years ago

@Neil-Ni FYI, Future of the project is to be decided, see #311