yalcin-ata / godot-android-plugin-firebase

Godot 3.2.2 Android plugin for Firebase
44 stars 12 forks source link

Events with no parameters should be supported #7

Open RandomShaper opened 4 years ago

RandomShaper commented 4 years ago

Events like the predefined tutorial_begin have no arguments, so they can be logged with a null Bundle, but this check is preventing it: https://github.com/yalcin-ata/godot-android-plugin-firebase/blob/6f1a46f97c45f16db2a8e250921431f16bb943a3/src/main/java/org/godotengine/androidplugin/firebase/Firebase.java#L246

My workaround so far is sending a dummy Dictionary, like { "_": "" }.

Ideally, the method should allow null and empty Dictionary.