yalelibrary / YUL-DC

Preliminary issue tracking for Yale University Libraries Digital Collections project
3 stars 0 forks source link

Don't delete Aspace Digital Objects when DCS Parent is marked Private #2126

Closed martinlovell closed 2 years ago

martinlovell commented 2 years ago

Currently, when a Parent in DCS is marked Private, the digital object is deleted from archives space.

Instead, it should keep the digital object and mark it private (publish=false).

Metadata cloud will handle setting publish=false for private items: https://github.com/yalelibrary/metadata-cloud/issues/420

DCS does not generate a DO when an item is private, which causes it to be deleted. It should generate one with private visibility.

martinlovell commented 2 years ago

https://github.com/yalelibrary/yul-dc-management/pull/1025

martinlovell commented 2 years ago

v2.59.43

motropuk commented 2 years ago

@martinlovell @ucancallmealicia @sshetenhelm do you have an example record I can use to test this?

martinlovell commented 2 years ago

Any parent with a digital object in Aspace should work.

e.g. https://collections-uat.library.yale.edu/management/parent_objects/900146267 https://puitestarchivesspace.library.yale.edu/repositories/6/archival_objects/2538740

If you make the parent private, after <30min the viewer and link should disappear from: https://puitestarchivesspace.library.yale.edu/repositories/6/archival_objects/2538740

If that all works, then check if the Digital Object is still in aspace but marked private.
I'm not sure of the best way to check that the Digital object is still in aspace. There may be a way through aspace test admin interface, or we could check through the API.

motropuk commented 2 years ago

Thanks @martinlovell I will test

motropuk commented 2 years ago

Looks good on UAT and ASpace test. See the DCS object for https://puitestarchivesspace.library.yale.edu/repositories/6/archival_objects/2538740 to Private. Disappeared from Test Archives at Yale after about 20 mins, and then checked the DO in Aspace Test and it was still present but set to be unpublished as expected. So good to close