yalelibrary / YUL-DC

Preliminary issue tracking for Yale University Libraries Digital Collections project
3 stars 0 forks source link

[BUG] Cyrillic script in 'Found in' breadcrumbs and Universal Viewer doesn't display correctly on parent object page #2552

Closed sshetenhelm closed 1 year ago

sshetenhelm commented 1 year ago

Story Romanization of Cyrillic script in the 'Found in' breadcrumbs is not displaying correctly on the parent object display page for objects. Instead, a box with an X inside appears. In the Universal Viewer, the markers look like the letter U but with a flat bottom (see screenshot).

We would like the Romanization of Cyrillic script to display correctly in the 'Found in' breadcrumbs on the parent object page in Blacklight and in the Universal Viewer title and within UV metadata fields.

Breadcrumbs display correctly on search results page, although the font for the 'special' characters looks different.

Screenshot: Image

Screenshot of UV 'More Information' panel: Image

Examples TEST: https://collections-test.library.yale.edu/catalog/800012852 https://collections-test.library.yale.edu/catalog/800013368 https://collections-test.library.yale.edu/catalog/800034792

Examples UAT: https://collections-uat.library.yale.edu/catalog/900036138 https://collections-uat.library.yale.edu/catalog/900037356 https://collections-uat.library.yale.edu/catalog/900051206

Examples PROD: https://collections.library.yale.edu/catalog/30700142 https://collections.library.yale.edu/catalog/30891202 https://collections.library.yale.edu/catalog/30067334 https://collections.library.yale.edu/catalog/30076056

Acceptance

mikeapp commented 1 year ago

Breadcrumb title may need fallback fonts listed in CSS. We may need to change fonts in UV's CSS - did QS team work on this?

jpengst commented 1 year ago

Looking for some feedback on the new font-weight additions in the UV:

Before (Chrome):

Image

After (Chrome):

Image

jpengst commented 1 year ago

Looks like we don't need to add the increased font-weight to the UV because it renders the Cyrillic fonts perfectly if we just use Arial:

Image

Note The breadcrumbs need the increased font-weight to render correctly on Chrome

jpengst commented 1 year ago

PR: https://github.com/yalelibrary/yul-dc-blacklight/pull/918

jpengst commented 1 year ago

Deployed to Test v1.60.80

K8Sewell commented 1 year ago

Looking good on Test. Will promote to UAT.

Image

sshetenhelm commented 1 year ago

Looks good on mac/Safari and mac/Firefox, but mac/Chrome does not like it. Still getting box icons in the Universal Viewer, even after (a) regenerating manifest and (b) using incognito browser.

The breadcrumbs look good though!

Screenshot:

Image

jpengst commented 1 year ago

Fix attempt 2 PR: https://github.com/yalelibrary/yul-dc-blacklight/pull/923

jpengst commented 1 year ago

Looks good on Chrome in Test:

Image

sshetenhelm commented 1 year ago

Looks good to me! Thank you so much :)

Ready to close.