yalelibrary / YUL-DC

Preliminary issue tracking for Yale University Libraries Digital Collections project
3 stars 0 forks source link

Turn off bookmarks for guest users? #2568

Closed mikeapp closed 5 months ago

mikeapp commented 1 year ago

Story

Guest users can bookmark items. We have also had problems on other systems with guest user accounts filling up the Users table. I suggest that we turn off guest users if possible (see https://groups.google.com/g/blacklight-development/c/2_cg97j97YE )

Acceptance

jpengst commented 1 year ago

PR: https://github.com/yalelibrary/yul-dc-blacklight/pull/922

jpengst commented 1 year ago

@mikeapp I think removing the devise-guests gem is a bit more complicated than described in the thread above. There's a bunch of references to token/current/guest users throughout blacklight that gets lost when the guests gem is removed.
As a temporary workaround to fulfill the ticket, I can keep the devise-guests gem and then limit the bookmark features to signed in users only. But I think removing the devise-guests gem would require a separate ticket. Thoughts on this?

Rob mentioned that guests can be auto-removed and we can set that job to run as often as we like.

jpengst commented 5 months ago

PR: https://github.com/yalelibrary/yul-dc-blacklight/pull/1019

K8Sewell commented 5 months ago

Deployed to Demo with commit

sshetenhelm commented 5 months ago

On feature branch, so ready to close. Thank you!