search

yalelibrary / YUL-DC

Preliminary issue tracking for Yale University Libraries Digital Collections project
3 stars 0 forks source link

Admin set keys missing from Batch Process table for 'Export by admin set' #2746

Closed sshetenhelm closed 7 months ago

sshetenhelm commented 8 months ago

Story In MGMT UAT, I did two 'Export parents by admin set' batch processes using the Batch Process Template that had two admin sets for each process, but the table is only displaying one.

Processes: Batch process 1816 Batch process 1803

Screenshot: Image

1816 should have both brbl and div 1803 should have both law and div

When exporting multiple admin sets, we would like all admin set keys to display in the Batch Process table.

Acceptance

jpengst commented 8 months ago

PR: https://github.com/yalelibrary/yul-dc-management/pull/1336

K8Sewell commented 8 months ago

Included in Management release v2.67.3

sshetenhelm commented 7 months ago

Tested with batch process 823.

Instead of displaying all 3 in the table, as I refreshed the 'batch process' page, it showed first only mus (which was first in the uploaded csv) and then only div (which was last in the uploaded csv). So, it's showing one at a time, in the order of the spreadsheet, as the process is... processed.

jpengst commented 7 months ago

I've done a few tests on test and local. It looks like this bug happens when the last item in the csv does not have any parent objects associated with it (in the BP 823 test case above, the div set does not have any PO's). Do we want the BP table to display all the admin sets that are present in the uploaded CSV? Or do we only want to show the admin sets that have parent objects in the set?

sshetenhelm commented 7 months ago

I think the best way would be to display all admin sets that were included in the csv, so users aren't under the impression that the process did not "read" that the admin set or something.

However, if that behavior is significantly more difficult to get working than having only admin sets that have parent objects, I would be satisfied to go that route as well. In PROD, there shouldn't be any "active" admin sets that don't have parents (JSS isn't in use so wouldn't matter).

jpengst commented 7 months ago

Yep, no problem! BP table will now display all admin sets that are present in the csv.
PR: https://github.com/yalelibrary/yul-dc-management/pull/1353

K8Sewell commented 7 months ago

Deployed to Test with release v2.67.8

sshetenhelm commented 7 months ago

Looks good on Test!

K8Sewell commented 7 months ago

Deployed to UAT

sshetenhelm commented 7 months ago

Works as expected on UAT! Thank you!

Ready to close :)