yalelibrary / YUL-DC

Preliminary issue tracking for Yale University Libraries Digital Collections project
3 stars 0 forks source link

[Discuss] Investigate SPA results - Jquery #2790

Closed laurenb33 closed 1 month ago

laurenb33 commented 3 months ago

We need to investigate and discuss how to apply the recommendations from the recent DCS SPA - starts on pg. 3 of the report (the link is in the Teams channel).

The second recommendation is to upgrade to the latest verision of jquery.

Important Links/Info from @mikeapp: jquery-rails includes versions 1, 2, and 3 for backward compatibility, so we would need to fork the gem and remove it. There is an outstanding PR for this. https://github.com/rails/jquery-rails/blob/master/VERSIONS.md https://github.com/rails/jquery-rails/pull/298 UV uses JQuery 3.x so should not be impacted

Acceptance

laurenb33 commented 2 months ago

In the February 2024 DCS SPA report, the second mitigation recommendation was that the identified library JQuery version should be upgraded. The development team would like to apply for an exception from this requirement because the tool, Universal Viewer, for DCS Blacklight already uses JQuery 3.x. The response in the report found the outdated JQuery v1.12 because the JQuery-rails gem includes versions 1 and 2 for backward compatibility. It is possible to fork the gem and make the modifications needed, but the community of developers for the JQuery-rails gem are currently working on a fix to stop supporting versions 1 and 2: https://github.com/rails/jquery-rails/blob/master/VERSIONS.md. This would be a heavy lift for our team to take on and maintain, especially when a fix is anticipated to be released soon.

DraxIndustries79 commented 2 months ago

Next:

sshetenhelm commented 2 months ago

We can close these as soon as we get confirmation from Lauren that she's shared these with George.

laurenb33 commented 1 month ago

I submitted this exception on 5/6 - ready to close!