yalelibrary / YUL-DC

Preliminary issue tracking for Yale University Libraries Digital Collections project
3 stars 0 forks source link

Display Terms and Conditions Bug #2807

Closed jpengst closed 1 month ago

jpengst commented 2 months ago

Summary

When creating a new Permission Set Term and Condition, the term will not display in Blacklight if the first line in the dialogue box is empty.

Example:

Image

This term will not display because of the empty line in the dialogue box.

Acceptance Criteria

sshetenhelm commented 2 months ago

Is this for any empty line, or just an empty line on the first line of the Terms?

If just triggered by an empty first line, could we have Management refuse to save the terms and display an error message for users if it detects that the first line is blank?

jpengst commented 2 months ago

Yeah, I was thinking this would be a management ticket. I think it would be some type of action in management that would either prevent the terms from being saved with an error message, or we would have some type of before_save action that will automatically remove any extra lines before saving the data.

jpengst commented 1 month ago

PR: https://github.com/yalelibrary/yul-dc-management/pull/1391

K8Sewell commented 1 month ago

Deployed to Demo with release v2.69.5

K8Sewell commented 1 month ago

Appears to be working as expected. Will bump to UAT.

Image

Image

jpengst commented 1 month ago

This bug fix is for displaying in Blacklight. Confirmed to be working:

image
K8Sewell commented 1 month ago

Failed to deploy worker containers so redeploying to UAT.

Image

K8Sewell commented 1 month ago

Waiting to deploy to UAT until testing for #2824 is completed.

laurenb33 commented 1 month ago

I changed the Cats TC with a blank first line and was able to view the TC in UV! :)

Image

Image