yalelibrary / YUL-DC

Preliminary issue tracking for Yale University Libraries Digital Collections project
3 stars 0 forks source link

Require Perm Set Key if OwP Object #2827

Closed K8Sewell closed 5 months ago

K8Sewell commented 6 months ago

In a .csv for batch process ingests, if "Open with Permission" is the item's intended visibility the Permission Set Key name needs to be included in the CSV. After the .csv is submitted, the authoritative JSON will also be checked (along with the csv) to see if the user has permission to change or modify the objects in a particular admin set. If the Perm Set Name is not included in the .csv, an error should be thrown in MGMT to let the user know that it needs to be included.

Acceptance:

K8Sewell commented 6 months ago

PR is green. Before taking it out of draft I wanted to check on the language for the batch errors. Are the error messages on these screenshots ok? ~ got ok in standup ~

Screenshots

Not in CSV Error

image

Permission Error

image

K8Sewell commented 5 months ago

Deployed to Demo with release v2.69.5

K8Sewell commented 5 months ago

Bumping to UAT so able to test with mssa Admin Set

Image

K8Sewell commented 5 months ago

Waiting to deploy to UAT until testing for #2824 is completed.

K8Sewell commented 5 months ago

Deploy is live on UAT for testing

sshetenhelm commented 5 months ago

Confirmed this works! Checked for both key and permissions. Thank you!

Ready to close :)