yalelibrary / YUL-DC

Preliminary issue tracking for Yale University Libraries Digital Collections project
3 stars 0 forks source link

Enable OwP Ingest with Preservica #2836

Closed K8Sewell closed 5 days ago

K8Sewell commented 1 month ago

Summary

No logic existed to handle the permission set value in a Preservica ingest. The PR below sets up this logic and enables ingests with Preservica to correctly create parent objects with OwP visibility.

PR

https://github.com/yalelibrary/yul-dc-management/pull/1387

K8Sewell commented 1 month ago

Deployed to UAT with release v2.69.3

sshetenhelm commented 1 month ago
sshetenhelm commented 1 month ago

I am not an administrator or approver for the Permission Set "Test Permission Set 01," but as a regular user, I was able to create a parent that goes into that set: https://collections-uat.library.yale.edu/management/parent_objects/901623974 Batch process - https://collections-uat.library.yale.edu/management/batch_processes/1960/parent_objects/901623974

...although still received the usual PTIFF errors.

K8Sewell commented 1 month ago

Summer, is it possible that you were still a sysadmin when the batch process - 1960 - was processed? I checked this morning and you are presently a sysadmin so out of curiosity I updated myself to not be a sysadmin and removed myself from the test_01(key) permission set and when I tried with the csv you used in 1960 I got the not permitted message as expected. I was not sure if you were set back to sysadmin since 1960 was processed - if so I'll keep investigating but thought it might be worth retesting if not.

Image

sshetenhelm commented 1 month ago

I'm 95% sure I was a regular user when I performed the process, but I will try again just to double-check.

sshetenhelm commented 1 month ago
  1. Removed self from Kissinger set
  2. Had Lauren make me normal user again
  3. Logged into UAT in incognito browser to make sure nothing was cached or something
  4. Uploaded spreadsheet with "kiss" Kissinger permission set in BP 1967
  5. Was able to create parent, but parent failed b/c of PTIFF error Do you think this may be because I originally created the Kissinger set?

Screenshot:

Image

sshetenhelm commented 1 month ago

Apparently I get to do whatever I want -- this batch process is with the "new" set JP created

K8Sewell commented 2 weeks ago

PR ready for review - https://github.com/yalelibrary/yul-dc-management/pull/1400

jpengst commented 2 weeks ago

Deployed to UAT v2.70.0

sshetenhelm commented 1 week ago

As per Batch Process 2043, I am still able to create a parent in a Permission Set that I am not an approver or administrator on, even when I am a regular staff user.

sshetenhelm commented 5 days ago

I've asked one of our staff members who have never been a SysAdmin in UAT to try and create a parent into a Permission Set they haven't been added to, in case there's something about my netID in particular that is linked with something. As long as regular, Never Been Sys'ed users can't create random OwP parents, we don't need this to be a blocker for the MVP release (although we should continue to investigate).

sshetenhelm commented 5 days ago

Confirmed that a Never Been Sys'ed user cannot create OwP object in OwP set they have not been added to:

https://collections-uat.library.yale.edu/management/batch_processes/2061

We can create a separate ticket to look into my superpowers, but I think the original goal of this ticket -- ensure OwP with Preservica ingests -- is completed.