yalelibrary / YUL-DC

Preliminary issue tracking for Yale University Libraries Digital Collections project

3 stars 0 forks source link

BUG: Access Requests Page Not Loading #2839

Closed K8Sewell closed 5 months ago

K8Sewell commented 6 months ago

Summary

Currently the route /permission_requests errors out with the generic rails error page.

Acceptance Criteria

[ ] /permission_requests loads correctly

Screenshot

sshetenhelm commented 6 months ago

Strange! I am able to see this and so were our testers today.

jpengst commented 6 months ago

The error:

Because the page loads for some people and not others, I think it might be erroring out on particular objects

jpengst commented 6 months ago

PR: https://github.com/yalelibrary/yul-dc-management/pull/1393

This was an issue whenever a user had a request in an "Approved" state but no Access Until date. Blacklight didnt know what to do with the nil access_until date. I created this PR that adds a validation for permission requests. A request can no longer be saved successfully if a request has "Approve" selected, but no access date selected. The access date field will now be highlighted red if nothing is selected:

jpengst commented 6 months ago

I also went into demo and added an access date to about 6 approved records that didn't have a date filled out. So that page should be fixed for everyone that was seeing the error :)

K8Sewell commented 6 months ago

Deployed to Demo with release v2.69.6

laurenb33 commented 5 months ago

I can see the page now! :)