yalelibrary / YUL-DC

Preliminary issue tracking for Yale University Libraries Digital Collections project

3 stars 0 forks source link

Fix Spec Failing on Blacklight Main #2852

Closed K8Sewell closed 2 weeks ago

K8Sewell commented 3 weeks ago

Summary

Failure has made it's way into the main branch on blacklight repo. From which change is undetermined as it was first discovered in the dependabot PR for nokogiri.

Acceptance Criteria

[x] main branch for blacklight passes CI successfully

Screenshot

K8Sewell commented 3 weeks ago

Flappy specs were the culprit - CI eventually passed on main without any changes. PR to mark the flappy specs as pending - until the test effectiveness / coverage tech debt work is ready.

PR ready for review - https://github.com/yalelibrary/yul-dc-blacklight/pull/1013

K8Sewell commented 3 weeks ago

Deployed to Test with release v1.61.8

K8Sewell commented 3 weeks ago

No issues noticed. Will promote to UAT.

sshetenhelm commented 2 weeks ago

Anything we need to do to double-check this, or are we ready to close?