yalelibrary / YUL-DC

Preliminary issue tracking for Yale University Libraries Digital Collections project
3 stars 0 forks source link

Permission Request Page Locks Up #2854

Closed K8Sewell closed 5 days ago

K8Sewell commented 3 weeks ago

Summary

If an admin or approver of a permission set forgets to set an Access Until value the page:

Acceptance Criteria

Screenshot

Image

jpengst commented 1 week ago

PR: https://github.com/yalelibrary/yul-dc-management/pull/1405

K8Sewell commented 1 week ago

Deployed to Test and Demo with release v2.70.3

sshetenhelm commented 1 week ago

Works as expected, but so sorry, could we please update the warning language to the following?:

Allow Access Until can’t be blank. Please select an Allow Access Until date. The user’s access will expire on this date.

Otherwise looks good!

jpengst commented 1 week ago

Fixed it! I learned how to add custom validation messages, so that's pretty cool :)

Image

PR: https://github.com/yalelibrary/yul-dc-management/pull/1406

K8Sewell commented 6 days ago

Deployed to Test and Demo with release v2.70.4

sshetenhelm commented 5 days ago

Works as expected on Demo! Thank you :)

Ready to close