search

yalelibrary / YUL-DC

Preliminary issue tracking for Yale University Libraries Digital Collections project
3 stars 0 forks source link

Can't remove users from Permission Set in Management #2904

Closed mikeapp closed 3 months ago

mikeapp commented 3 months ago

Story

As a system admin user I would like to be able to remove approvers/administrators from a Permission Set.

Image

Acceptance

jpengst commented 3 months ago

@mikeapp What happens if you create a PS on UAT or test? Can you access the permission sets after that? I was having the same error on UAT and I'm able to view the sets again after creating one. I'm not sure whats causing this behavior. Still investigating.

mikeapp commented 3 months ago

I created another set and saw the x icons. I think the problem may be that I added myself as an approver to the set shown in the description. Perhaps having both roles caused it?

sshetenhelm commented 3 months ago

Here's something else to add to this ticket -- now I can't remove Mike as an administrator, even though (a) I receive a flash message confirming his removal and (b) I can add/remove other sys admins. This was in Test. Video: https://drive.google.com/file/d/1zW_4LoAEIHjXOI9ppo_rWGduMmNilnCA/view?usp=sharing

jpengst commented 3 months ago

Im also getting an error page when trying to view Mikes profile in /users:

Image

Im able to replicate this locally though, so working on a fix. It's tied to the issue of not being able to remove the user from permission set as well.

jpengst commented 3 months ago

PR: https://github.com/yalelibrary/yul-dc-management/pull/1422

K8Sewell commented 3 months ago

Deployed to Test with release v2.71.3

K8Sewell commented 3 months ago

Editing and viewing capabilities restored on Test. Will promote to UAT.

No option to remove self from permission set

Image

Able to remove and add users for permission set

Image

Image

Image

sshetenhelm commented 3 months ago
  1. Receiving 'We're sorry, something went wrong' for Kait and JP through Users page (but can access Mike's page now).
  2. Cannot remove Kait and JP as Perm Set Admins. Video.
  3. CAN remove Kait and JP as Perm Set Approvers.
  4. CAN remove other users as Perm Set Admin/Approvers.
jpengst commented 3 months ago

We need to delete a few corrupted roles on Test and UAT. That will fix both the 'We're sorry, something went wrong' messages on our profiles as well as being able to remove from admin list. Test: ed396, ks2552, mikea UAT: ac2254, je459, ks2552

K8Sewell commented 3 months ago

Corrupted roles have been deleted from Test and UAT.

sshetenhelm commented 3 months ago

Lookin' good on Test and UAT! Ready to close :) Thanks!