yalelibrary / YUL-DC

Preliminary issue tracking for Yale University Libraries Digital Collections project
3 stars 0 forks source link

Gracefully Handle No Terms #2937

Closed K8Sewell closed 2 months ago

K8Sewell commented 2 months ago

Summary

In Blacklight when a user visits a parent object that belongs to a Permission Set that does not have terms they are directed to a generic Rails error page. There is code that is meant to handle empty terms so this ticket is to review and fix whatever has changed from the initial testing of this feature and now.

Acceptance Criteria

Engineering Notes

There is a 'no implicit conversion of nil to string' error. Assumption is that the page is trying to render the nil terms and it is breaking all the things. There should be a catch already that guards against no terms but that does not appear to be playing ball.

Screenshots

Image Image Image

jpengst commented 2 months ago

PR: https://github.com/yalelibrary/yul-dc-blacklight/pull/1060

K8Sewell commented 2 months ago

Deployed to Test with release v1.64.3

K8Sewell commented 2 months ago

Looking good on Test. Able to load page of parent object of permission set with no terms successfully and display error message when no terms are found. Will promote to UAT.

Image Image

K8Sewell commented 2 months ago

Waiting to deploy to UAT until other ticket in release (#2931 ) has passed QA.

sshetenhelm commented 2 months ago

Looks good on UAT! Thank you so much :) Ready to close