yalla-coop / chiltern-website

0 stars 0 forks source link

Map of services #99

Closed katieshuster closed 1 year ago

katieshuster commented 1 year ago

Please select the priority level by adding one of the following labels to this issue

Describe the bug The map is not correctly showing the number of staff/groups in some locations.

To Reproduce Steps to reproduce the behavior: If you go to the map and click on Standlake you should see that there is 1 music therapist there image

Expected behavior You should see that there is one music therapist in Standlake as there is a tag for that: image

Screenshots

Desktop (please complete the following information): Windows Google Chrome

Smartphone (please complete the following information):

Additional context I think this may be a problem for other areas but I haven't tested all the locations

Team - do not edit @thejoefriel @fadeomar @@Israa91

fadeomar commented 1 year ago

hey @katieshuster I've investigated the issue but not sure what is the bug because the custom code works fine, but I've noticed that you have listed a long list of cities in one item in the CMS and tried to keep just 5 cities but the item at it works and fixed the issue, so here is the way to avoid this case from happening again is whenever you notice that the items in the city are more than 5 items you should stop adding a city to that item and duplicate the item to add the new cities to it so the image above will represent now in two items with the same data but with different cities SO image

will become 1- image 2- image

I hope that I make it clear as possible and it's ready for testing

katieshuster commented 1 year ago

Hi Fade, this makes sense, however I have just tested it and this seems to be appearing on the page? https://www.loom.com/share/15ed9d98a3d64f38b4a30f7bfe42ef0a

fadeomar commented 1 year ago

hey @katieshuster this was by mistake, it's fixed now

katieshuster commented 1 year ago

Is it possible to remove this white space underneath the map? image

fadeomar commented 1 year ago

hey @katieshuster I was checking this issue, but it seem to be fixed, please check https://www.loom.com/share/be1e0bb307c8430aa062988e156dae51 and let me if it happened again

katieshuster commented 1 year ago

Hi @fadeomar I have done a hard refresh and deleted the cache and I still have the white space I'm afraid https://www.loom.com/share/140c2e8682d44405845bbd5d202f66b7

fadeomar commented 1 year ago

hey @katieshuster I've invistgate the issue again and fix it, you can test again :+1:

katieshuster commented 1 year ago

Thanks @fadeomar that's good now!