Feature/data filtering - Githubissues

yalla-coop / curenetics

A platform enabling medical professionals to more quickly find relevant clinical trials for their patients

2 stars 0 forks source link

Feature/data filtering #47

Closed martinbagshaw closed 4 years ago

martinbagshaw commented 5 years ago

A work in progress, initial filter functions to filter search results from Jamie's API. No tests yet, but pushed in case I get hit by the proverbial bus.
Uses a node module to use fetch in node (as opposed to the front end). This may not be required in the final version.
Relates to #2 and #3

martinbagshaw commented 5 years ago

For viewers: I do not intend for this branch to be merged, more used as a point of reference for data filtering functions we might use or adapt to filter API results with.

I will probably continue working on this sort of thing unless someone says I shouldn't - been enjoying it, and I feel it may be useful.

martinbagshaw commented 5 years ago

@thejoefriel I have hit a bit of a blocker here, I was wondering if you could help me out?

When running deepEquals tests, it appears that some test data I am importing is getting mutated. If I comment out either one of the last tests in filterFunctions.test.js, tests all pass.

I was wondering if you have encountered this before, and if so, how you solved it?

Thanks.

MohammedYehia commented 5 years ago

@mr-bagglesworth sorry for that that was the prettier thing I forgot to stop it. I agree and I will try and do some test as we agreed