Same idea as for the design discussion, thought I'd make a new issue to separate the two.
Add your tips and todos here.
In changes made in #77 (already made here, but I guess @othman-shamla noticed that) - I have a couple of things to add:
Input id should match label for- in react this is htmlFor to not get confounded with javascript for.
buttons to have aria-label
...other than that looks pretty damn good. I've not cracked open the code, but I do see some bits that allude to inline styling in the console though, rather than
Moving forward, the modal / pop up thing that we are creating to tell the users that they will lose their results if they refresh etc. is worth digging into as I understand this can be a bit more tricky to implement. We could implement this ourselves, though if we would prefer to use a package:
general accessibility guidance from React
Same idea as for the design discussion, thought I'd make a new issue to separate the two. Add your tips and todos here.
In changes made in #77 (already made here, but I guess @othman-shamla noticed that) - I have a couple of things to add:
idshould match labelfor- in react this ishtmlForto not get confounded with javascript for.aria-label...other than that looks pretty damn good. I've not cracked open the code, but I do see some bits that allude to inline styling in the console though, rather than
Moving forward, the modal / pop up thing that we are creating to tell the users that they will lose their results if they refresh etc. is worth digging into as I understand this can be a bit more tricky to implement. We could implement this ourselves, though if we would prefer to use a package: