Open jema28 opened 3 years ago
Mentioned this on discord/slack but would also be good to sort the deployment so the site's on the Yalla account. @thejoefriel could you send over the details for this?
@jema28 thanks for sharing this here are my thoughts:
I like having the accents on desktop and tablet so I have no problem removing them on mobile, the current design looks fine to me and I will do my best to bring it to live
I wouldn't like to make a lot of changes to the current Figma design as we were waiting for it to be finished for a good time and I'm just concerned that we keep making changes to it cause that will delay the final release of the project
There won't be a lot of first versions of the site I was helping with getting something done by Sunday and my plan was to continue working + merging the changes we need into master so that we can ship it by the end of this month max
I agree we need to pass metadata to the case studies and handle styling better, I am willing to discuss using normal React pages instead of MDX but the reasons I went with MDX in the first place are:
I noticed your comments on having problems with MDX what issues did you have?
and I would like to keep the release-v1 branch as the production/deployed branch and stop creating newer versions and go for a full release of the website does that work well with you both? @jema28 and @thejoefriel
Was taking a look at the content of the case studies and I realized they don't look as similar as I thought they would and I'm now considering to ditch MDX because as I said MDX is better for building blogs or something like that where you have a lot of text content but in our case, the case studies have a lot of common components inside them.
Thanks @yosefanajjar!
I like the landing page as it is now on desktop and tablet. The only parts I'd change back are approach section and work section once we have the extra case studies. In general, if we go back to the original design for desktop, we need to be a bit careful about responsiveness, spacing and alignment - I can go check this as we go. I really like some of the sections without accents e.g. this part of the landing page -
I think the approach page could go back to the original but need to watch the responsiveness again.
Yeh the versions of the site was more aimed at me as there will be new case studies and tweaks that I will work on in the future.
I like the case studies sharing the same header look but need to look into going back to the original design for the first sections of the case study pages.
The case study content may be different in the future but I think mdx was confusing to me, especially the lack of indents and mixing styled components in.
Yeh the next release will be everything in figma. Anything else released in the future I'll sort.
@fadeomar Heard from Yosef that you're working on the team pages, thank you! Wanted to make sure you read the message above that we're not having accents on mobile and the introduction on each page should be free from accents also (on all sizes). Let me know if that's all clear?
@jema28 would be better if you go ahead and remove the accents we don't need from the Figma it will help me and @fadeomar understand better, let me know if that's possible!
Sure, I'll go through and do this @yosefanajjar, will put it under 'Mockups-v2'
Hi @thejoefriel @yosefanajjar,
Having a think about next steps and adding the rest of the pages. Here are a few initial thoughts:
On the current design - release-v1:
Approach suggestion for the next pages:
Priorities:
Would be good to get your thoughts on the above @thejoefriel @yosefanajjar in this thread 😸