yallie / unzip

Tiny unzip helper class for .NET 3.5 Client Profile and Mono 2.10, written in pure C#.
http://nuget.org/packages/unzip
MIT License
28 stars 3 forks source link

Cleaned up the CRC32 calculation #5

Closed perlun closed 11 years ago

perlun commented 11 years ago

Hi,

As noted in #3, there was some cleanup needed (IMHO) with the CRC32 calculation. Here are my suggested changes. Please take a look and see what you think! I think there are still some things which could get fixed; I wrote some TODO about it in the code. Feel free to explore and/or modify these changes also to your likings.

In general, I strongly believe in the principles outlaid by "Uncle Bob" in the Clean Code book. If you haven't read it, I strongly recommend it. Very quick summary:

Best regards, Per

yallie commented 11 years ago

Hi Per! Thanks a lot for your contributions! But you didn't answer my question about the progress event #3:

As for this event, I am going to convert it to EventArgs-based handler. Will ProgressChangedEventArgs suit your needs? Using it, I can pass the file name along with the percentage.