Build with -strict-sequence

yallop / ocaml-ctypes

Library for binding to C libraries using pure OCaml

MIT License

369 stars 95 forks source link

Build with -strict-sequence #613

Closed Armael closed 4 years ago

Armael commented 4 years ago

This PR enables -strict-sequence and allows building ctypes with it enabled. This is related to the proposal of enabling -strict-sequence by default in ocaml/ocaml#1971, in order to make ctypes forward compatible.

(I can restrict the PR to the change in commands.mli if you would rather avoid modifying the build instructions themselves; although enabling the option there makes sure the issue will not come back later).

yallop commented 4 years ago

Thanks. This is currently failing with some errors in the testsuite, but I'm happy to merge once those are fixed.

Armael commented 4 years ago

I think I fixed the testsuite (the failure on android looks unrelated).