search

yallop / ocaml-ctypes

Library for binding to C libraries using pure OCaml
MIT License
369 stars 95 forks source link

[WIP] Remove PosixTypes #648

Open toots opened 4 years ago

toots commented 4 years ago

This PR is a follow-up from #624 to remove internal posix types after release of the external posix-types here: https://github.com/savonet/ocaml-posix

I tried to use the external posix types but it gets tricky as they rely on the ctypes API/ABI. It might be possible with a git module but I highly discourage it.

It should also be possible to re-export from external posix-types into the legacy PosixTypes module if we feel like it'll be a good idea.

I will release the external ocaml-posix next.

yallop commented 4 years ago

It's good to see the ocaml-posix work progressing.

Removing PosixTypes altogether is quite a drastic step. We discussed deprecating the PosixTypes module in #624; could we do that instead?

toots commented 4 years ago

Yes, agreed, that's why I marked the PR a WIP for now. I wanted to see what the end game looked like before deprecating.

I think I'll port the examples and tests that were removed to the new posix-types.