search

yallop / ocaml-ctypes

Library for binding to C libraries using pure OCaml
MIT License
363 stars 95 forks source link

Guard include path with quotes #664

Closed Firobe closed 3 years ago

Firobe commented 3 years ago

If the path of the current build directory contains spaces (or other special chars), the whole build of ocaml-ctypes fails since at one point it uses that path without guards in CFLAGS.

A simple way to reproduce the current bug :

  1. Clone ctypes to "/tmp/space dir"
  2. opam install .

Thankfully the fix is simple

yallop commented 3 years ago

Thank you!

The Windows and macOS builds are failing, but it appears to be unrelated, so I'll merge this.