Incompatible pointer types error

jamesjer commented 2 months ago

Describe the bug

context When I compile ocaml-ctypes 0.23.0 with gcc 14.1.1 and run the tests, one test fails. GCC 14.x is stricter about incompatible pointer types than previous versions of GCC.

expectation I expect the tests to pass.

bug But instead the compiler throws an error:

generated_stubs.c: In function ‘cstubs_tests_2_new_chorse’:
generated_stubs.c:14:25: error: initialization of ‘struct animal *’ from incompatible pointer type ‘struct chorse *’ [-Wincompatible-pointer-types]
   14 |    struct animal* x10 = new_chorse(x7);
      |                         ^~~~~~~~~~

This code appears to have been generated from tests/test-oo_style/stubs/functions.ml, lines 84 and 85.

problem This is a problem for Linux distribution packagers, because we want to see package tests succeed.

Reproduce the bug

Gain access to a machine with GCC 14.x; I am using Fedora Rawhide.
Build ocaml-ctypes 0.23.0
Run the tests

List your environment

The following Fedora packages are installed (not a complete list; devel packages are also installed in most cases):

gcc-14.1.1-7.fc41.x86_64
libffi-3.4.6-2.fc41.x86_64
ocaml-5.2.0-3.fc41.x86_64
ocaml-bigarray-compat-1.1.0-17.fc41.x86_64
ocaml-bisect-ppx-2.8.3-13.fc41.x86_64
ocaml-dune-3.16.0-3.fc41.x86_64
ocaml-dune-configurator-3.16.0-3.fc41.x86_64
ocaml-integers-0.7.0-16.fc41.x86_64
ocaml-lwt-5.7.0-13.fc41.x86_64
ocaml-ounit-2.2.7-11.fc41.x86_64

yallop commented 2 months ago

Thank you for the report, @jamesjer. There's a fix for the test in #785. I can make a 0.23.1 release that includes the fix, if that'd be useful.

jamesjer commented 2 months ago

Thank you for the quick response! I'm okay with waiting until the next time you have a reason to make a release, actually. I can patch the test locally until then.

yallop / ocaml-ctypes